Skip to content

fix: add home section #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix: add home section #769

wants to merge 22 commits into from

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Aug 5, 2025

Fix #702, fix #498, fix #257

Screenshot 2025-08-14 at 09 53 46 Screenshot 2025-08-14 at 09 57 56

@github-actions github-actions bot added the enhancement General improvements to existing features label Aug 5, 2025
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review August 6, 2025 12:41
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner August 6, 2025 12:41
Copy link
Contributor

@klmcadams klmcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

return

home_entry = (
nodes.Text("Package Home"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we imposing this to always be Package Home? I thought we agreed on just writing Home here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mia suggested having the package at home in this comment last week, but we can discuss this further.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.. "Package Home" looks too verbose and weird .. I'd sugggest moving to "Home"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like Package Home is too long.. Home is consistent with the logo 🏠 we see in the breadcrumps. To me @mia-guo-ux didn't mean Package in the label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinging @mia-guo-ux here , for insights

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germa89 @Revathyvenugopal162

To avoid confusion, we initially adopted the term Package Home, since Home alone could be misinterpreted as referring to the broader PyAnsys home.

One potential improvement would be to simplify the label to just Home, while providing additional context through a tooltip. For example, hovering over "Home" could display a tooltip like PyAEDT Home, clearly indicating the specific package being referenced.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the tool tip, and renamed to home

@Revathyvenugopal162 Revathyvenugopal162 requested review from jorgepiloto and a team August 13, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop allowing users to customize logo link Add home section in the navigation bar Modify the link from the pyansys logo in docs
7 participants